Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: Warn when argTypesRegex used with visual test addon #26094

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Feb 19, 2024

Closes #25405

What I did

Warn when argTypesRegex is used together with the visual test addon:

image

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen force-pushed the kasper/warn-argtypes-regex-test-addon branch 3 times, most recently from 1c917f6 to ed566da Compare February 19, 2024 13:25
@kasperpeulen kasperpeulen force-pushed the kasper/warn-argtypes-regex-test-addon branch from ed566da to 952dba5 Compare February 19, 2024 13:31
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we have other documentation about best practices for fn() it's probably worth linking it at the bottom of the warning so that people can learn more.

@shilman shilman assigned shilman and kasperpeulen and unassigned shilman Feb 19, 2024
@shilman shilman changed the title Action: Warn when argTypesRegex is used together with the visual test addon Addon-actions: Warn when argTypesRegex is used together with the visual test addon Feb 19, 2024
@kasperpeulen kasperpeulen merged commit 05787fe into next Feb 19, 2024
44 of 49 checks passed
@kasperpeulen kasperpeulen deleted the kasper/warn-argtypes-regex-test-addon branch February 19, 2024 15:22
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
26 tasks
@shilman shilman changed the title Addon-actions: Warn when argTypesRegex is used together with the visual test addon Addon-actions: Warn when argTypesRegex is use with visual test addon Feb 20, 2024
@shilman shilman changed the title Addon-actions: Warn when argTypesRegex is use with visual test addon Addon-actions: Warn when argTypesRegex used with visual test addon Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when argTypesRegex is used together with the visual test addon
2 participants