Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: tabId for toolbar addons #25848

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Docs: tabId for toolbar addons #25848

merged 2 commits into from
Feb 1, 2024

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Feb 1, 2024

What I did

Telescopes from #25792

Documents new tabId property in a toolbar addon's match function.

Checklist for Contributors

Testing

Manual testing

  1. Follow the steps in the contributing instructions for this branch, docs-tabId.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Feb 1, 2024
@kylegach kylegach self-assigned this Feb 1, 2024
Base automatically changed from jeppe/25322-bug-main-section-disappears-when-navigating-to-addon-tab to next February 1, 2024 08:45
@ndelangen ndelangen merged commit f1062fa into next Feb 1, 2024
17 checks passed
@ndelangen ndelangen deleted the docs-tabid branch February 1, 2024 09:56
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Fails
🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against 4fe8e1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants