Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix about page layout #25396

Merged
merged 9 commits into from
Jan 2, 2024
Merged

UI: Fix about page layout #25396

merged 9 commits into from
Jan 2, 2024

Conversation

cdedreuille
Copy link
Contributor

@cdedreuille cdedreuille commented Dec 31, 2023

What I did

This PR fixes some layout regression on the about page and on the closing button on pages (top right):

  • Fix alignments in the about page on desktop
  • Replace buttons with the correct ones in multiple places
  • Fix the "What's new" footer buttons
  • Fix close button alignment by removing Flexbar. We will deprecate this component very soon.
  • Replaced Storybook icon + text with Storybook logo
  • Fix SidebarIconButton styles
  • Remove ToolbarMenu - Not used anymore anywhere.

CleanShot 2023-12-31 at 19 26 20@2x

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Open Storybook UI
  2. Check that all alignments and spacings are correct both on desktop and mobile

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@cdedreuille cdedreuille self-assigned this Dec 31, 2023
@cdedreuille cdedreuille changed the title Fix about page layout UI: Fix about page layout Dec 31, 2023
@cdedreuille cdedreuille added ci:daily Run the CI jobs that normally run in the daily job. ui maintenance User-facing maintenance tasks labels Dec 31, 2023
@cdedreuille cdedreuille marked this pull request as ready for review January 1, 2024 08:37
@shilman
Copy link
Member

shilman commented Jan 2, 2024

@cdedreuille why are you using the ci: daily label? I think ci: normal would be sufficient and it consumes a LOT fewer resources!

@cdedreuille
Copy link
Contributor Author

@shilman Mostly because @JReinhold told me so 😅. I can use ci:normal going forward.

@cdedreuille cdedreuille added ci:normal and removed ci:daily Run the CI jobs that normally run in the daily job. labels Jan 2, 2024
@cdedreuille cdedreuille merged commit 4bcf971 into next Jan 2, 2024
58 checks passed
@cdedreuille cdedreuille deleted the charles-fix-pages-layout branch January 2, 2024 14:53
@github-actions github-actions bot mentioned this pull request Jan 2, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants