Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: Remove deprecated vue packages from next #25108

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Dec 4, 2023

Fixes #24779

What I did

Remove deprecated vue packages from next, as otherwise we keep publishing new version on the next tag.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

socket-security bot commented Dec 4, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: vue@2.6.14

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more stuff to remove, eg. the CLI generator for Vue2.

Take a look at next...remove-deprecated-packages, I also took a stab at this but never got around to opening a PR. (I might also not have gotten everything though, or removed too much, so just look at it for inspiration)

Copy link

socket-security bot commented Dec 5, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -206,8 +206,7 @@ const frameworkToRenderer: Record<SupportedFrameworks | SupportedRenderers, Supp
solid: 'solid',
svelte: 'svelte',
sveltekit: 'svelte',
vue: 'vue',
vue3: 'vue',
vue3: 'vue3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this map is used for, but is this change correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed to me that this was a bug. But maybe good if @ndelangen or @yannbf could have a quick look at this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like this code is only used here:

if (includeCommonAssets) {
const rendererType = frameworkToRenderer[renderer] || 'react';
await adjustTemplate(join(destinationPath, 'Configure.mdx'), { renderer: rendererType });
}

It's just modifying the Configure.mdx a little bit with some string replacement.

I think it should not mention vue3, but rather say vue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kasperpeulen kasperpeulen merged commit ee46686 into next Dec 6, 2023
57 of 58 checks passed
@kasperpeulen kasperpeulen deleted the kasper/remove-deprecated-packages branch December 6, 2023 16:03
@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 7, 2023
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
4 tasks
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate @storybook/vue in 7.6
3 participants