Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Fix Vite 5 CJS warnings #25005

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Vite: Fix Vite 5 CJS warnings #25005

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
add44fc
dynamic import vite to force ESM mode
JReinhold Nov 28, 2023
78f1c35
improve readability of list of sandbox templates
JReinhold Nov 28, 2023
3fc9be5
add eslint rule to enforce dynamic vite imports
JReinhold Nov 28, 2023
52e2345
Merge branch 'next' into fix-vite5-cjs-warnings
JReinhold Nov 28, 2023
fd63dc9
Merge remote-tracking branch 'origin/next' into fix-vite5-cjs-warnings
kasperpeulen Jan 3, 2024
a88b242
Remove unneeded mergeConfig
kasperpeulen Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve readability of list of sandbox templates
  • Loading branch information
@JReinhold
JReinhold committed Nov 28, 2023
commit 78f1c3569f55c1500aa6ab96ab45dddabd3fcaf5
5 changes: 3 additions & 2 deletions scripts/utils/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,12 @@ export function getOptions<TOptions extends OptionSpecifier>(

const checkStringValue = (raw: string) => {
if (option.values && !option.values.includes(raw)) {
const possibleOptions = chalk.cyan(option.values.join(', '));
const possibleOptions = chalk.cyan(option.values.join('\n'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated to this PR, was it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but intentional. The message was pretty unreadable, so I just quickly improved it slightly

throw new Error(
dedent`Unexpected value '${chalk.yellow(raw)}' for option '${chalk.magenta(key)}'.

These are the possible options: ${possibleOptions}\n\n`
These are the possible options:
${possibleOptions}\n\n`
);
}
return raw;
Expand Down