Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Downgrade @testing-library/user-event to 14.3.0 #25004

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Nov 28, 2023

What I did

Downgrade testing library to 14.3.0 to prevent firefox issues testing-library/user-event#1075

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25004-sha-c5268c93. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-25004-sha-c5268c93
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/downgrade-testing-lib
Commit c5268c93
Datetime Tue Nov 28 11:29:09 UTC 2023 (1701170949)
Workflow run 7018090961

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25004

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@testing-library/user-event 14.3.0 None +0 256 kB testing-library-bot

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen merged commit f304715 into next Nov 28, 2023
59 of 72 checks passed
@kasperpeulen kasperpeulen deleted the kasper/downgrade-testing-lib branch November 28, 2023 11:06
@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 28, 2023
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
6 tasks
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
Test: Downgrade @testing-library/user-event to 14.3.0
(cherry picked from commit f304715)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants