Actions: Fix @storybook/core-events/preview-errors dependency missing for Yarn PnP

[JReinhold]

What I did

Moved @storybook/core-events from a devDependency to a regular dependency in @storybook/addon-actions.

#24856 introduced an import to @storybook/core-events/preview-errors. All of @storybook/core-events is being externalized by the bundler, but @storybook/core-events/preview-errors is not globalized. This means that it's importing from a package that doesn't exist in the dependency tree. The real fix here is to also globalize sub-exports like ./preview-errors, but that's a bigger task.

Yarn PnP is very strict about this, but this doesn't seem to affect any of the other package managers.

cc @kasperpeulen

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24973-sha-64de488b. Install it by pinning all your Storybook dependencies to that version.

More information

Published version	0.0.0-pr-24973-sha-64de488b
Triggered by	@JReinhold
Repository	storybookjs/storybook
Branch	fix-actions-pnp
Commit	64de488b
Datetime	Fri Nov 24 10:51:15 UTC 2023 (1700823075)
Workflow run	6979838876

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24973

[ndelangen]

We could also globalize these paths, that's possibly a better approach.

[JReinhold]

What do you mean? We already globalize @storybook/core-events?

[ndelangen]

right, but each entrypoint must be globalized separately, LMK