Viewport: Add newer device viewports #24777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
|
I'll add this for 7.x, but kinda want to reduce this list if not entirely remove it from our codebase, perhaps in 8.0. We can't have this list grow to infinity, and it's included into the bundle even if left unused. |
ndelangen
approved these changes
Nov 14, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This pull request introduces updates to the
INITIAL_VIEWPORTSconfiguration in Storybook. The aim of these changes is to ensure that the Storybook environment stays current with the devices used for UI display, which are relevant in the current industry standards.The updated INITIAL_VIEWPORTS configuration now includes the following devices:
These additions to the INITIAL_VIEWPORTS configuration are essential for maintaining alignment with current industry standards. They ensure that stakeholders have a clear understanding of the devices utilized for showcasing user interfaces within Storybook.
before after
https://github.com/storybookjs/storybook/assets/57059705/9ed4f961-353b-4b77-a051-efe550cdecc1 https://github.com/storybookjs/storybook/assets/57059705/12be530b-642c-4a80-8e15-7ee0ae132dbd
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Ran sandbox locally and verified all the added devices are working as expected.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>