Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing supported extension check in case when asset is a string #2468

Merged
merged 2 commits into from
Dec 12, 2017
Merged

fix missing supported extension check in case when asset is a string #2468

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b0798
fix missing supported extension check in case when asset is a string
Dec 12, 2017
5645a0a
fix no-extra-boolean-cast eslint error
Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/vue/src/server/iframe.html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ const urlsFromAssets = assets => {
.forEach(key => {
let asset = assets[key];
if (typeof asset === 'string') {
urls[getExtensionForFilename(asset)].push(asset);
if (Boolean(urls[getExtensionForFilename(asset)])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but we usually just do !!(urls[getExtensionForFilename(asset)]) to convert into boolean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I copied it from few lines below. But actually it can be simplified to just if (urls[getExtensionForFilename(asset)]) { ... } - otherwise CircleCI test fails at no-extra-boolean-cast rule.

urls[getExtensionForFilename(asset)].push(asset);
}
} else {
if (!Array.isArray(asset)) {
asset = [asset];
Expand Down