Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Allow Yarn v4 in link command #24551

Merged
merged 1 commit into from
Oct 23, 2023
Merged

CLI: Allow Yarn v4 in link command #24551

merged 1 commit into from
Oct 23, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Oct 23, 2023

Closes #

What I did

Yarn 4 was released, and our scripts had a check for yarn version that did not include it. It's fixed now

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Oct 23, 2023
@JReinhold JReinhold merged commit 4ee42ac into next Oct 23, 2023
53 checks passed
@JReinhold JReinhold deleted the yann/fix-link-command branch October 23, 2023 09:56
@JReinhold JReinhold added patch:yes Bugfix & documentation PR that need to be picked to main branch maintenance User-facing maintenance tasks cli and removed build Internal-facing build tooling & test updates labels Oct 23, 2023
@JReinhold JReinhold changed the title Build: Allow yarn 4 in link command CLI: Allow Yarn v4 in link command Oct 23, 2023
storybook-bot pushed a commit that referenced this pull request Oct 23, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
6 tasks
storybook-bot pushed a commit that referenced this pull request Oct 24, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 24, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 24, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 24, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 25, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 25, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 25, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 25, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 26, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 27, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 27, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
storybook-bot pushed a commit that referenced this pull request Oct 30, 2023
Build: Allow yarn 4 in link command
(cherry picked from commit 4ee42ac)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants