Maintenance: Remove need for react
as peerDependency
#23897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23882
What I did
I found out the problem that was causing #23876, so instead of reverting the whole thing, we fix it proper.
How to test
To reproduce:
v1.7.161
tag, which is where the issue was found: https://github.com/mkosir/react-parallax-tilt/tree/v1.7.161npm run start-storybook
- it should work@storybook/addon-essentials
and@storybook/manager-api
npm install
thennpm run start-storybook
- it should fail0.0.0-pr-23897-sha-78c2d886
npm run start-storybook
- it should work!Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This pull request has been released as version
0.0.0-pr-23897-sha-78c2d886
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-23897-sha-78c2d886
revert-23882-revert-23496-norbert/react-peerdep-webpack-builder-removal
78c2d886
1692602787
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23897