-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Blocks: Add support for of
prop to Primary
block
#23849
Merged
JReinhold
merged 26 commits into
storybookjs:next
from
Wilson2k:update-primary-block-of-prop
Oct 19, 2023
Merged
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
79c2201
Updated primary block to support of prop
Wilson2k f720962
Removed use of any type
Wilson2k 92c7a3f
Merge branch 'next' into update-primary-block-of-prop
Wilson2k d2c6faa
Revert back to satisfies operator for Primary, improve API docs
Wilson2k 9da4588
Merge branch 'update-primary-block-of-prop' of https://github.com/Wil…
Wilson2k fb9f274
Merge branch 'next' into update-primary-block-of-prop
Wilson2k d19c4c6
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 19fb867
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 73a3c31
Merge branch 'next' into update-primary-block-of-prop
jonniebigodes bc01165
Merge branch 'next' into update-primary-block-of-prop
Wilson2k b36c473
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 9bff994
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 0daba67
Merge branch 'next' into update-primary-block-of-prop
Wilson2k ebfd6b1
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 25ebc72
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 739278c
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 2adab92
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 6313c9e
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 5b2f817
Merge branch 'next' into update-primary-block-of-prop
Wilson2k e3d4e1d
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 9198f30
Update code/ui/blocks/src/blocks/Primary.tsx
Wilson2k 57ac6ba
Update migration docs
Wilson2k 393b0db
Merge branch 'next' into update-primary-block-of-prop
Wilson2k d3cabc6
Removed getPrimaryFromResolvedOf function
Wilson2k 132f0a8
Merge branch 'next' into update-primary-block-of-prop
Wilson2k 066258f
Merge branch 'next' into update-primary-block-of-prop
Wilson2k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for not realising this sooner, I just thought of it now. I think now that we supply
'meta'
as the only valid type, we don't need the "complex" error handling ingetPrimaryFromResolvedOf
, as that is already done withinuseOf
based on the second argument - it should even be typed correctly.So maybe you could try this and remove
getPrimaryFromResolvedOf
entirely and see if that still works?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for the late reply, I just tested it and it seems to work fine. Good catch, I'll push a commit with the changes.