Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add support for Nuxt framework #23663

Draft
wants to merge 29 commits into
base: next
Choose a base branch
from
Draft

CLI: Add support for Nuxt framework #23663

wants to merge 29 commits into from

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Jul 31, 2023

Closes #

What I did

I added support for NUXT project to the CLI,

  • create nuxt-vite/default-ts sandbox

How to test

To create repo template run

yarn task --task generate --template nuxt-vite/default-ts

To create sandbox from template:

yarn task --task sandbox --template nuxt-vite/default-ts

For init run inside Nuxt project

'yarn storybook initornpx storybook@next init`

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@chakAs3 chakAs3 changed the title CLI:add Cli for Nuxt framework CLI:add support for Nuxt framework Jul 31, 2023
code/lib/cli/src/detect.ts Outdated Show resolved Hide resolved
scripts/utils/yarn.ts Outdated Show resolved Hide resolved
@chakAs3 chakAs3 changed the title CLI:add support for Nuxt framework CLI: add support for Nuxt framework Jul 31, 2023
chakAs3 and others added 3 commits July 31, 2023 16:21
Co-authored-by: Yann Braga <yannbf@gmail.com>
Co-authored-by: Yann Braga <yannbf@gmail.com>
Co-authored-by: Yann Braga <yannbf@gmail.com>
@ndelangen
Copy link
Member

@chakAs3 please add detailed "What I did" and "How to test".

@chakAs3
Copy link
Contributor Author

chakAs3 commented Jul 31, 2023

@chakAs3 please add detailed "What I did" and "How to test".

thanks, @ndelangen and @yannbf for the quick review, i did not yet finish I'm adding some description and cleaning up

@chakAs3
Copy link
Contributor Author

chakAs3 commented Jul 31, 2023

This seems very unrelated to this PR. Could you undo this?

yes but this version is creating a conflict for me for some reason, that is why i had to change however i have other solution i will add it the
package resolutions

@ndelangen ndelangen marked this pull request as draft July 31, 2023 14:06
@yannbf yannbf changed the title CLI: add support for Nuxt framework CLI: Add support for Nuxt framework Aug 2, 2023
@kasperpeulen kasperpeulen self-assigned this Aug 9, 2023
@kasperpeulen
Copy link
Contributor

@chakAs3 Is this one ready to be reviewed?

@kasperpeulen
Copy link
Contributor

I checked it out.

I got this error:
image

It seems like the template directory is missing:
image

I do see it is here, but maybe somehow ignored when publishing to npm?
https://github.com/storybook-vue/nuxt/tree/main/template/cli

@chakAs3
Copy link
Contributor Author

chakAs3 commented Aug 11, 2023

It seems like the template directory is missing:

no it is there maybe not the last version .

let me update deps

@valentinpalkovic
Copy link
Contributor

Any updates on this PR? What does it need to get it merged?

Copy link
Contributor Author

chakAs3 commented Oct 2, 2023

Hi @valentinpalkovic i have get back on it. it is been 2 months

@valentinpalkovic valentinpalkovic removed their request for review October 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Empathy Backlog
Development

Successfully merging this pull request may close these issues.

5 participants