Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix target id in searchfield label #23464

Merged
merged 8 commits into from
Sep 5, 2023
Merged

UI: Fix target id in searchfield label #23464

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
16d0156
search label for attribute doesn't match id of input (fixes #23463)
Jul 14, 2023
303bc06
Merge branch 'next' into 23463-search-input-label-for
yannbf Aug 15, 2023
129335f
Merge branch 'next' into 23463-search-input-label-for
ndelangen Sep 4, 2023
5a27579
Merge branch 'next' into 23463-search-input-label-for
yannbf Sep 4, 2023
95bdc7e
small refactor
yannbf Sep 4, 2023
f3463e7
Merge branch 'next' into 23463-search-input-label-for
yannbf Sep 5, 2023
2ef76cf
Merge branch 'next' into 23463-search-input-label-for
yannbf Sep 5, 2023
089c182
Merge branch 'next' into 23463-search-input-label-for
yannbf Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions code/ui/manager/src/components/sidebar/Search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,9 @@ export const Search = React.memo<{
}
}

const inputId = 'storybook-explorer-searchfield';
const inputProps = getInputProps({
id: 'storybook-explorer-searchfield',
id: inputId,
ref: inputRef,
required: true,
type: 'search',
Expand All @@ -361,9 +362,13 @@ export const Search = React.memo<{
onBlur: () => setPlaceholder('Find components'),
});

const labelProps = getLabelProps({
htmlFor: inputId,
});

return (
<>
<ScreenReaderLabel {...getLabelProps()}>Search for components</ScreenReaderLabel>
<ScreenReaderLabel {...labelProps}>Search for components</ScreenReaderLabel>
<SearchField
{...getRootProps({ refKey: '' }, { suppressRefError: true })}
className="search-field"
Expand Down