Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate netlify instances #2340

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Conversation

cheapsteak
Copy link
Member

@cheapsteak cheapsteak commented Nov 19, 2017

This is for having separate netlify instances for docs + each example

https://deploy-preview-2340--storybooks.netlify.com/
https://deploy-preview-2340--storybooks-cra.netlify.com/
https://deploy-preview-2340--storybooks-vue.netlify.com/

Once merged, we should be able to link to

https://storybooks.netlify.com/
https://storybooks-cra.netlify.com/
https://storybooks-vue.netlify.com/

Note:

  1. Seems sometimes builds aren't deterministic. This build failed due to "Cannot find module 'webpack'", but a rebuild (with no code changes) was successful
  2. The Github PR integration seems to only show the most recently added Netlify instance (Vue) image

@codecov
Copy link

codecov bot commented Nov 19, 2017

Codecov Report

Merging #2340 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2340   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      730      730           
=======================================
  Hits         1305     1305           
  Misses       4302     4302           
  Partials      549      549
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/babel_config.js 77.41% <0%> (+77.41%) ⬆️
app/vue/src/server/config/babel.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4901bc...865d193. Read the comment docs.

@cheapsteak cheapsteak force-pushed the cheapsteak/separate-netlify-instances branch from 9058b02 to 3f32ce1 Compare November 19, 2017 02:59
@cheapsteak cheapsteak force-pushed the cheapsteak/separate-netlify-instances branch from 3f32ce1 to 865d193 Compare November 19, 2017 03:09
@cheapsteak cheapsteak requested a review from a team November 19, 2017 03:24
@cheapsteak cheapsteak changed the title separate netlify build tasks (WIP, making PR to trigger netlify deploy preview) Separate netlify build tasks Nov 19, 2017
@cheapsteak cheapsteak changed the title Separate netlify build tasks Separate netlify instances Nov 19, 2017
@ndelangen ndelangen merged commit e2876e3 into master Nov 19, 2017
@ndelangen ndelangen deleted the cheapsteak/separate-netlify-instances branch November 19, 2017 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants