-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router: Support RegExp
in Route
component
#23292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… split into separate types & use overloads for improved type-safety
ndelangen
changed the title
Router: supporting regex in the Route component
Router: Supporting regex in the Jul 4, 2023
Route
component
valentinpalkovic
approved these changes
Jul 4, 2023
ndelangen
changed the title
Router: Supporting regex in the
Router: Supporting Jul 4, 2023
Route
componentRegExp
in the Route
component
ndelangen
changed the title
Router: Supporting
Router: Support Jul 4, 2023
RegExp
in the Route
componentRegExp
in the Route
component
ndelangen
changed the title
Router: Support
Router: Support Jul 4, 2023
RegExp
in the Route
componentRegExp
in Route
component
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
ndelangen
added a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets
release/7.2
to not disrupt the7.1
release.What I did
RegExp
as a path prop.How to test
/
) to a story, then to settings page should work.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]