Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Add --open/--no-open flag to dev command #22964

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 7, 2023

Relates to #22871

What I did

As title explains

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template angular-cli/default-ts
  2. Run yarn storybook --no-open
  3. It should not open Storybook

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 7, 2023
@yannbf yannbf requested a review from a team as a code owner June 7, 2023 14:17
@yannbf yannbf merged commit a6436a7 into next Jun 7, 2023
@yannbf yannbf deleted the fix/allow-open-flag-in-angular-binary branch June 7, 2023 15:10
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 8, 2023
shilman pushed a commit that referenced this pull request Jun 8, 2023
…ular-binary

Angular: Add --open/--no-open flag to dev command
@JReinhold JReinhold changed the title Angular: Add --open/--no-open flag to dev command Angular: Add --open/--no-open flag to dev command Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants