Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add experimental status API #22890

Merged
merged 7 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions code/lib/manager-api/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import * as releaseNotes from './modules/release-notes';
// eslint-disable-next-line import/no-cycle
import * as stories from './modules/stories';

// eslint-disable-next-line import/no-cycle
import * as refs from './modules/refs';
import * as layout from './modules/layout';
import * as shortcuts from './modules/shortcuts';
Expand Down
26 changes: 26 additions & 0 deletions code/lib/manager-api/src/modules/stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import {
} from '../lib/stories';

import type { ComposedRef, ModuleFn } from '../index';
import { merge } from '../index';

const { FEATURES, fetch } = global;
const STORY_INDEX_PATH = './index.json';
Expand All @@ -61,11 +62,22 @@ type ViewMode = 'story' | 'info' | 'settings' | string | undefined;
type StoryUpdate = Partial<
Pick<API_StoryEntry, 'prepared' | 'parameters' | 'initialArgs' | 'argTypes' | 'args'>
>;
interface StatusObject {
status: 'pending' | 'success' | 'error' | 'warn' | 'unknown';
title: string;
description: string;
data?: any;
}

type StatusState = Record<StoryId, Record<string, StatusObject>>;
type StatusUpdate = Record<StoryId, StatusObject>;

type DocsUpdate = Partial<Pick<API_DocsEntry, 'prepared' | 'parameters'>>;

export interface SubState extends API_LoadedRefData {
storyId: StoryId;
viewMode: ViewMode;
status: StatusState;
}

export interface SubAPI {
Expand Down Expand Up @@ -102,6 +114,7 @@ export interface SubAPI {
updateStory: (storyId: StoryId, update: StoryUpdate, ref?: API_ComposedRef) => Promise<void>;
updateDocs: (storyId: StoryId, update: DocsUpdate, ref?: API_ComposedRef) => Promise<void>;
setPreviewInitialized: (ref?: ComposedRef) => Promise<void>;
experimental_updateStatus: (id: string, update: StatusUpdate) => Promise<void>;
ndelangen marked this conversation as resolved.
Show resolved Hide resolved
}

const removedOptions = ['enableShortcuts', 'theme', 'showRoots'];
Expand Down Expand Up @@ -406,6 +419,18 @@ export const init: ModuleFn<SubAPI, SubState, true> = ({
fullAPI.updateRef(ref.id, { previewInitialized: true });
}
},

/* EXPERIMENTAL APIs */
experimental_updateStatus: async (id, update) => {
const { status } = store.getState();
const addition = Object.entries(update).reduce<StatusState>((acc, [storyId, value]) => {
acc[storyId] = acc[storyId] || {};
acc[storyId][id] = value;

return acc;
}, {});
await store.setState({ status: merge(status, addition) }, { persistence: 'session' });
},
};

const initModule = async () => {
Expand Down Expand Up @@ -575,6 +600,7 @@ export const init: ModuleFn<SubAPI, SubState, true> = ({
viewMode: initialViewMode,
hasCalledSetOptions: false,
previewInitialized: false,
status: {},
},
init: initModule,
};
Expand Down
114 changes: 108 additions & 6 deletions code/lib/manager-api/src/tests/stories.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { Channel } from '@storybook/channels';
import type { API_StoryEntry, StoryIndex, API_PreparedStoryIndex } from '@storybook/types';
import { getEventMetadata } from '../lib/events';

import type { SubAPI } from '../modules/stories';
import { init as initStories } from '../modules/stories';
import type Store from '../store';
import type { ModuleArgs } from '..';
Expand Down Expand Up @@ -125,12 +126,14 @@ describe('stories API', () => {
viewMode: 'story',
} as ModuleArgs);

expect(state).toEqual({
previewInitialized: false,
storyId: 'id',
viewMode: 'story',
hasCalledSetOptions: false,
});
expect(state).toEqual(
expect.objectContaining({
previewInitialized: false,
storyId: 'id',
viewMode: 'story',
hasCalledSetOptions: false,
})
);
});

describe('setIndex', () => {
Expand Down Expand Up @@ -1629,4 +1632,103 @@ describe('stories API', () => {
);
});
});

describe('experimental_updateStatus', () => {
it('is included in the initial state', () => {
const { state } = initStoriesAndSetState({
storyId: 'id',
viewMode: 'story',
} as ModuleArgs);

expect(state).toEqual(
expect.objectContaining({
status: {},
})
);
});

it('updates a story', async () => {
const fullAPI = Object.assign(new EventEmitter());
const navigate = jest.fn();
const store = createMockStore();

const { init, api } = initStoriesAndSetState({ store, navigate, provider, fullAPI } as any);

const API: SubAPI = Object.assign(fullAPI, api, {
setIndex: jest.fn(),
findRef: jest.fn(),
setRef: jest.fn(),
});

await init();

await expect(
API.experimental_updateStatus('a-addon-id', {
'a-story-id': {
status: 'pending',
title: 'an addon title',
description: 'an addon description',
},
})
).resolves.not.toThrow();

expect(store.getState().status).toMatchInlineSnapshot(`
Object {
"a-story-id": Object {
"a-addon-id": Object {
"description": "an addon description",
"status": "pending",
"title": "an addon title",
},
},
}
`);
});

it('updates multiple stories', async () => {
const fullAPI = Object.assign(new EventEmitter());
const navigate = jest.fn();
const store = createMockStore();

const { init, api } = initStoriesAndSetState({ store, navigate, provider, fullAPI } as any);

const API: SubAPI = Object.assign(fullAPI, api, {
setIndex: jest.fn(),
findRef: jest.fn(),
setRef: jest.fn(),
});

await init();

await expect(
API.experimental_updateStatus('a-addon-id', {
'a-story-id': {
status: 'pending',
title: 'an addon title',
description: 'an addon description',
},
'another-story-id': { status: 'success', title: 'a addon title', description: '' },
})
).resolves.not.toThrow();

expect(store.getState().status).toMatchInlineSnapshot(`
Object {
"a-story-id": Object {
"a-addon-id": Object {
"description": "an addon description",
"status": "pending",
"title": "an addon title",
},
},
"another-story-id": Object {
"a-addon-id": Object {
"description": "",
"status": "success",
"title": "a addon title",
},
},
}
`);
});
});
});