CLI: Provide Typescript templates for Preact #21689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
commented
Mar 20, 2023
|
|
||
| export const LoggedIn: Story = { | ||
| args: { | ||
| // @ts-expect-error TODO seems like props extraction in Story type is not correct |
There was a problem hiding this comment.
@kasperpeulen could you assist on this one? Thanks <3
kasperpeulen
reviewed
Aug 4, 2023
| } satisfies Meta<typeof Header>; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof meta>; |
There was a problem hiding this comment.
We don't support this yet in Preact!
There was a problem hiding this comment.
Should be StoryObj<HeaderProps>
kasperpeulen
requested changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
The CLI only contained JS templates for Preact. This PR adds Typescript (and 4.9) to it.
How to test
yarn task --task sandbox --start-from auto --template preact-vite/default-tsChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]