New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack: Support .cjs extension #18502

Merged

shilman merged 4 commits into storybookjs:next from ddalpange:support-cjs

Jun 29, 2022

Contributor

ddalpange commented Jun 17, 2022 •

edited

Loading

Issue: N/A

What I did

I can't resolve my package that was made as commonjs .
I added to .cjs extension in webpack rule -> test

How to test

Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.


          Support .cjs extension

e8ae710

nx-cloud bot commented Jun 17, 2022 •

edited

Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37cd0c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

Sent with 💌 from NxCloud.

MichaelArestad assigned ndelangen

MichaelArestad added the feature request label

ndelangen reviewed

View reviewed changes

app/angular/src/server/framework-preset-angular-cli.test.ts Outdated Show resolved Hide resolved

ndelangen reviewed

View reviewed changes

lib/builder-webpack4/src/preview/iframe-webpack.config.ts Outdated Show resolved Hide resolved

ndelangen reviewed

View reviewed changes

lib/builder-webpack5/src/preview/iframe-webpack.config.ts Outdated Show resolved Hide resolved

ndelangen reviewed

View reviewed changes

lib/manager-webpack4/src/presets/manager-preset.ts Outdated Show resolved Hide resolved

ndelangen reviewed

View reviewed changes

lib/manager-webpack5/src/presets/manager-preset.ts Outdated Show resolved Hide resolved

ndelangen requested changes

View reviewed changes

Member

ndelangen left a comment

I fear changing the order of these resolve configs will be a problem for other users...

ndelangen and others added 3 commits

June 28, 2022 23:54


          Merge branch 'next' into pr/ddalpange/18502

287ac96


          Fix order of extensions

2625f6a


          Updatet snaphots

37cd0c2

shilman added core configuration babel / webpack labels

shilman changed the title ~~Support .cjs extension~~ Webpack: Support .cjs extension

shilman approved these changes

View reviewed changes

Member

shilman left a comment

LGTM. Thanks so much for doing this @ddalpange !!!

shilman merged commit 7eef5f0 into storybookjs:next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration babel / webpack core feature request