Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix init to install correct version of sb/storybook #18417

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 6, 2022

Issue: N/A

What I did

We're now installing sb on init, so we need the correct version in the versions map.

We also need to update the lookup to find sb/storybook

Self-merging @ndelangen

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented Jun 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e66504b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title CLI: Fix versions map to include sb/storybook packages CLI: Fix sb init to install correct version of sb/storybook Jun 6, 2022
@shilman shilman changed the title CLI: Fix sb init to install correct version of sb/storybook CLI: Fix init to install correct version of sb/storybook Jun 6, 2022
@shilman shilman merged commit d8de5fd into future/base Jun 6, 2022
@shilman shilman deleted the future/fix-versions-map branch June 6, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant