Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Update x-default-browser and fix issue with package. #18277

Merged
merged 9 commits into from
Jul 1, 2022
Merged

Security: Update x-default-browser and fix issue with package. #18277

merged 9 commits into from
Jul 1, 2022

Conversation

The-Code-Monkey
Copy link
Contributor

Issue:

Update x-default-browser to updated version, with fix for mac that will remove the default-browser-id error on mac os.

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented May 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 669c265. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@The-Code-Monkey
Copy link
Contributor Author

@shilman @yannbf this is the updated package with the fix that you had to revert earlier today. I have added a test to catch Mac issues in my package so this shouldn't happen again. My bad for missing a test.

@ndelangen
Copy link
Member

Can I see the code you changed please?

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @The-Code-Monkey

I'm sorry but this seems a little bit suspicious. I hope you understand. Please show me the security changes you made to the package?

@The-Code-Monkey
Copy link
Contributor Author

Hi there yeah I fully understand, all I have done is updated the project to typescript as well as update the packages contained within so that they do not have any open security issues on GitHub.

https://github.com/The-Code-Monkey/TechStack/tree/dev/packages/x-default-browser

Here is the link for the code location.

@The-Code-Monkey
Copy link
Contributor Author

Let me know if you want me to make any changes or anything. I have the dependencies automatically updating so if anything new comes out there will be a relevant patch version.

@ndelangen
Copy link
Member

I checked it 🟢

@The-Code-Monkey thank you for this PR, I really appreciate it. I'll be merging this as soon as the CI goes green 👍

# Conflicts:
#	yarn.lock
@The-Code-Monkey
Copy link
Contributor Author

@ndelangen No worries, happy to help out when I can, If you do find any issues with the package feel free to add issues to the TechStack Mono Repo and I will get to them as soon as I can. And like I said, its going to auto update with the use of renovate bot and auto publish to npm.

@kalkin
Copy link

kalkin commented Jul 14, 2022

Any chance you will do a release soon containing this change?

@shilman
Copy link
Member

shilman commented Jul 14, 2022

@kalkin yes after we have a bunch of people on 7.0 alpha to verify that the new version works well

@tyru
Copy link

tyru commented Dec 21, 2022

@shilman Do you have any plan to fix this issue in 6.x.x version?

@shilman
Copy link
Member

shilman commented Dec 21, 2022

@tyru this fell off my radar. I'll patch it back and release in 6.5 alpha this week

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 21, 2022
@The-Code-Monkey
Copy link
Contributor Author

@shilman I have moved this package to a new org name. It's now under @techstack/x-default-browser

This won't be changing again but package will keep getting security updates

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants