docs: replaced 'as ComponentMeta' in TypeScript stories #17481
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Unsafe TypeScript examples
What I did
I refactored all TypeScript stories and removed the
as ComponentMeta<typeof Example>
type assertions. In my opinion, we should use the type as we would other types too (e.g.const foo: Foo = { hello: 'world' }
). We should not useas
as a way of typing this when it is not the last resort because TypeScript can't infer the type, shouldn't we? 🤔I am curious to hear what you think. :)
Maybe related PRs and Issues
How to test
If your answer is yes to any of these, please make sure to include it in your PR.