Core: Fix webpack stats #14198
Merged
Core: Fix webpack stats #14198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ndelangen
reviewed
Mar 11, 2021
| @@ -8,7 +8,7 @@ | |||
| "do-storyshots-puppeteer": "../../node_modules/.bin/jest --projects=./storyshots-puppeteer", | |||
| "generate-addon-jest-testresults": "jest --config=tests/addon-jest.config.json --json --outputFile=stories/addon-jest.testresults.json", | |||
| "graphql": "node ./graphql-server/index.js", | |||
| "packtracker": "yarn storybook --smoke-test --webpack-stats-json --quiet && cross-env PT_PROJECT_TOKEN=1af1d41b-d737-41d4-ac00-53c8f3913b53 packtracker-upload --stats=./node_modules/.cache/storybook/public/manager-stats.json", | |||
| "packtracker": "yarn storybook --smoke-test --webpack-stats-json /tmp --quiet && cross-env PT_PROJECT_TOKEN=1af1d41b-d737-41d4-ac00-53c8f3913b53 packtracker-upload --stats=/tmp/manager-stats.json", | |||
There was a problem hiding this comment.
Suggested change
| "packtracker": "yarn storybook --smoke-test --webpack-stats-json /tmp --quiet && cross-env PT_PROJECT_TOKEN=1af1d41b-d737-41d4-ac00-53c8f3913b53 packtracker-upload --stats=/tmp/manager-stats.json", | |
| "packtracker": "yarn storybook --smoke-test --webpack-stats-json=/tmp --quiet && cross-env PT_PROJECT_TOKEN=1af1d41b-d737-41d4-ac00-53c8f3913b53 packtracker-upload --stats=/tmp/manager-stats.json", |
ndelangen
reviewed
Mar 11, 2021
Comment on lines
+42
to
+47
| export const makeStatsFromError: (err: string) => Stats = (err) => | ||
| ({ | ||
| hasErrors: () => true, | ||
| hasWarnings: () => false, | ||
| toJson: () => ({ warnings: [] as any[], errors: [err] }), | ||
| } as any); |
There was a problem hiding this comment.
Is this something we want to export?
In the future we'll want to map the builders internal stats object to something common for all builders.
Right now we're leaking webpack details from our 2 builders. This is a known issue, but we should be really careful to not make that situation worse.
There was a problem hiding this comment.
I'm thinking something like SyntacticEvent in React, where the underlaying raw event is still available, but there's a layer on top to smooth out the browser differences. (except we're smoothing out the builder differences)
There was a problem hiding this comment.
Yes, I think that's the plan for 6.3 (or whenever we add our next builder).
We probably shouldn't be exporting this function however, that was an oversight.
ndelangen
approved these changes
Mar 11, 2021
ghengeveld
reviewed
Mar 11, 2021
| 'Write Webpack Stats JSON to disk', | ||
| resolvePathInStorybookCache(`public/`) | ||
| ) | ||
| .option('--webpack-stats-json [directory]', 'Write Webpack Stats JSON to disk') |
| 'Write Webpack Stats JSON to disk', | ||
| resolvePathInStorybookCache(`public/`) | ||
| ) | ||
| .option('--webpack-stats-json [directory]', 'Write Webpack Stats JSON to disk') |
This was referenced Mar 11, 2021
Merged
Closed
Merged
This was referenced Mar 14, 2021
Closed
Bump @storybook/addon-actions from 6.2.0-alpha.22 to 6.2.0-beta.14
openlattice/lattice-fabricate#743
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14139
What I did
Forgot to push this final commit on other PR (!)