Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in getstorybook project type detection #1195

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 5, 2017

Issue: #1193

What I did

Fix typo

How to test

Did not test. Run getstorybook in a project with no devDependencies and it will break, as in the issue.

@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #1195 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1195   +/-   ##
=======================================
  Coverage   13.31%   13.31%           
=======================================
  Files         199      199           
  Lines        4589     4589           
  Branches      526      603   +77     
=======================================
  Hits          611      611           
+ Misses       3518     3456   -62     
- Partials      460      522   +62
Impacted Files Coverage Δ
lib/cli/lib/detect.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.14% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 41.66% <0%> (ø) ⬆️
app/react/src/client/preview/render.js 0% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a247cd...0eba277. Read the comment docs.

@shilman shilman changed the title Fix typo in CLI project detection Fixed typo in getstorybook project type detection Jun 5, 2017
@ndelangen ndelangen merged commit 6b26566 into master Jun 5, 2017
@ndelangen ndelangen deleted the shilman-patch-2 branch June 5, 2017 12:34
@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog and removed in progress labels Jun 5, 2017
@ndelangen ndelangen added this to the v3.0.2 milestone Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants