Skip to content

[Bug]: SolidJS deprecated package #26332

Open
@jonniebigodes

Description

Describe the bug

When a user installs the latest version of Storybook in their SolidJS project out of the box, he automatically gets the now deprecated @storybook/testing-library as part of the installation process. Also, the examples provided relate to the package. This presents a disconnect where the user is presented with a deprecated package and examples irrelevant to the current version of Storybook, where we introduced the @storybook/test package as the default one. For example:
storybook-rc-solid-packages-stories

This issue becomes more relevant if they try to upgrade from a previous Storybook version (e.g., 7.5/7.6) to the latest version, where two things happen:

  • The user is prompted to remove the @storybook/testing-library package from the project as part of the upgrade process.
  • The package is installed as a direct dependency and not as a dev dependency as other Storybook packages, as shown below
storybook-solid-upgrade-issue.mp4

I'm aware that SolidJS is not part of the core frameworks we support, is currently maintained by the community, and may not be on par with the other frameworks we support. However, it would be in our best interest to ensure that if the @storybook/test package is not supported, we should not install it as part of the migration process. Or if it is supported, we should provide the relevant examples (i.e., the Button component example for args mocking) and fix the package to be installed as a dev dependency.

cc @vanessayuenn @kasperpeulen @JReinhold

To Reproduce

  • Set up a SolidJS project
  • Install the latest Storybook version
  • Run the upgrade process

System

No response

Additional context

No response

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions