Merge pull request #16912 from TrevorBurnham/trevorburnham/fix-story-…

…group-viewmode fix(storybook): Use parameters from first story in group
storybookjs · Jun 30, 2022 · f0a4b55 · f0a4b55
2 parents f6e17dc + a4e5171
commit f0a4b55
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/api/src/lib/stories.ts b/lib/api/src/lib/stories.ts
@@ -282,9 +282,12 @@ export const transformStoriesRawToStoriesHash = (
     rootAndGroups.forEach((group, index) => {
       const child = paths[index + 1];
       const { id } = group;
+      // @ts-ignore
+      const { parameters: originalParameters = group.parameters } = acc[id] || {};
       acc[id] = merge(acc[id] || {}, {
         ...group,
         ...(child && { children: [child] }),
+        parameters: originalParameters,
       });
     });
 

diff --git a/lib/api/src/tests/stories.test.js b/lib/api/src/tests/stories.test.js
@@ -84,6 +84,8 @@ describe('stories API', () => {
     });
   });
   const parameters = {};
+  const firstInGroupParameters = { viewMode: 'docs' };
+  const secondInGroupParameters = { viewMode: 'story' };
   const storiesHash = {
     'a--1': {
       kind: 'a',
@@ -112,15 +114,15 @@ describe('stories API', () => {
     'b-d--1': {
       kind: 'b/d',
       name: '1',
-      parameters,
+      parameters: firstInGroupParameters,
       path: 'b-d--1',
       id: 'b-d--1',
       args: {},
     },
     'b-d--2': {
       kind: 'b/d',
       name: '2',
-      parameters,
+      parameters: secondInGroupParameters,
       path: 'b-d--2',
       id: 'b-d--2',
       args: { a: 'b' },
@@ -229,6 +231,7 @@ describe('stories API', () => {
         id: 'b-d',
         parent: 'b',
         children: ['b-d--1', 'b-d--2'],
+        parameters: firstInGroupParameters,
         isRoot: false,
         isComponent: true,
       });
@@ -239,7 +242,7 @@ describe('stories API', () => {
         parent: 'b-d',
         kind: 'b/d',
         name: '1',
-        parameters,
+        parameters: firstInGroupParameters,
         args: {},
         prepared: true,
       });
@@ -250,7 +253,7 @@ describe('stories API', () => {
         parent: 'b-d',
         kind: 'b/d',
         name: '2',
-        parameters,
+        parameters: secondInGroupParameters,
         args: { a: 'b' },
         prepared: true,
       });