Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(story-exports): stop highlighting the entire code on error #91

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 15, 2022

Issue: N/A

What Changed

The story-exports highlight was done on the entire file which was weird.

Now it highlights the first non-import statement:
image

Might still be a little weird, but better than before for sure. @shilman Thoughts?

Checklist

Check the ones applicable to your change:

  • Ran yarn update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

@yannbf yannbf added the patch Increment the patch version when merged label Apr 15, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/rules/story-exports.ts Show resolved Hide resolved
@yannbf yannbf merged commit 74d0c68 into main Apr 16, 2022
@yannbf yannbf deleted the fix/story-exports-error-highlighting branch April 16, 2022 15:32
@github-actions
Copy link

🚀 PR was released in v0.5.10 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants