Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom settings using ReactGA.set() #1

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented Jun 28, 2021

Passing custom dimensions or settings can be useful when segmenting dev audiences, for example:

window.STORYBOOK_GA_OPTIONS = {
  set: {
    appName: 'design-system',
    isUsingCloudEnvironment: true,
  },
};

What I did

Introduced a new STORYBOOK_GA_OPTIONS object, where a set object can be passed, using this format: https://developers.google.com/analytics/devguides/collection/analyticsjs/command-queue-reference#set

The README and stories should be updated, but first I'd like to get feedback on this API.

@kaelig
Copy link
Contributor Author

kaelig commented Sep 14, 2022

Bumping this up, hoping for a review!

@ndelangen ndelangen merged commit f09a0ee into storybookjs:next Jan 16, 2023
@kaelig kaelig deleted the patch-1 branch January 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants