Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eslint flat config #1240

Merged
merged 4 commits into from
Sep 26, 2024
Merged

chore: eslint flat config #1240

merged 4 commits into from
Sep 26, 2024

Conversation

alvarosabu
Copy link
Contributor

This PR introduces eslint flat config and fixes the current issues with linters. Also removes pre-commit strategies and replace them with CI/CD checks

@alvarosabu alvarosabu added the p1-chore [Priority] Doesn't change end-user code behavior (priority) label Sep 25, 2024
@alvarosabu alvarosabu self-assigned this Sep 25, 2024
edodusi
edodusi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@edodusi edodusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We see some inconsistencies with the code style of js files due to an issue with eslint-react-hooks, we decided to move on with this and return to the js styles later.

@alvarosabu alvarosabu merged commit 7d90ecd into main Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edodusi edodusi edodusi approved these changes

Assignees

@alvarosabu alvarosabu

Labels
p1-chore [Priority] Doesn't change end-user code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarosabu @edodusi