Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request throttling #72

Merged
merged 1 commit into from
May 23, 2024

Conversation

marcesengel
Copy link
Contributor

@marcesengel marcesengel commented Sep 12, 2023

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

See #64.

What is the new behavior?

  • Storyblok SDK client is cached as long as the parameters stay the same

Other information

Credit @PhiFry for suggesting this fix, see #64 (comment).

Can be installed from GitHub using npm i -D cashy-at/storyblok-cli#fix/request-throttling, feel free to give it a try!

@marcesengel marcesengel changed the title fix: request throttling Fix request throttling Sep 12, 2023
@marcesengel
Copy link
Contributor Author

@ademarCardoso a review from you would be much appreciated!

@grantunwindojo
Copy link

Can confirm this works! Although I have no powers here!

@pH-7
Copy link

pH-7 commented Nov 8, 2023

Who are the active maintainers of this repo? Is it still Ademar Cardoso?

@marcesengel
Copy link
Contributor Author

Looks like it, this is the latest merged PR (last week by @ademarCardoso).

@RoettingerJ
Copy link

Same behavior with 3.26.0
Still getting
...
X An error occurred when create component
Error: Too Many Requests
...
when pushing blok configuration file with 23 bloks
Can somebody please have a look on this - thanks in advance

@ItsMeDelanoDev
Copy link

Anyone?

@roberto-butti roberto-butti mentioned this pull request May 17, 2024
5 tasks
@roberto-butti
Copy link

Hi @marcesengel , I had the same issue, and I opened a PR to fix the "hitting rate limit issue." I didn't notice your PR.

I think that your PR is better than mine 🎉. (especially for the check also for the region and tokens)
I tested your PR (but with the updated codebase), and it works like a charm 🙏

Copy link
Contributor

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @marcesengel for the contribution. Highly appreciated

@alvarosabu alvarosabu merged commit 505356a into storyblok:master May 23, 2024
Copy link

🎉 This PR is included in version 3.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants