Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO-658] - Update Asset, Multiasset and Multilink types #122

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

Edo-San
Copy link
Contributor

@Edo-San Edo-San commented Sep 26, 2024

This PR aims to fix the creation of Asset, Multiasset and Multilink field types created by the generate-typescript-typedefs command.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

  • Pull components' schema from a space
  • Run generate-typescript-typedefs command against that schema

What is the new behavior?

The types for Asset, Multiasset and Multilink should be up to date now.

Copy link

@alvarosabu alvarosabu merged commit 43327b7 into master Oct 4, 2024
1 check failed
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 3.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@LukasHechenbergerID
Copy link

@Edo-San Hello, quick question which is related to this change.

Why should for example filename in AssetStoryblok always be nullable, even if the Asset is set as required in Storyblok?
Is there a possibility to implement that?
I just changed from the old package to this and the typing for assets was a easier that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants