Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(space-nuxt-base): turn the isValidQuery method less strict #87

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

demetriusfeijoo
Copy link
Contributor

@demetriusfeijoo demetriusfeijoo commented Sep 20, 2024

What?

It changes the isValidQuery method to be less strict so the query parameters received in the success callback of the OAuth flow are valid and can be passed ahead to the other routes, otherwise, the appSession would not be created and added to the context correctly, making the application break.

Error
image
image

Steps to reproduce

  1. Open the Algolia Plugin
  2. Clean all the Algolia data stored in the browser
  3. Reload the page
  4. Click on the Settings button on the top-right corner of the screen
  5. The error page should be displayed

Detailed OAuth flow:
https://github.com/storyblok/space-tool-plugins/blob/main/space-plugins/nuxt-base/server/utils/getAppSession.ts#L9

How to test? (optional)

@demetriusfeijoo demetriusfeijoo changed the title fix: turn the isValidQuery method less strict fix(space-nuxt-base): turn the isValidQuery method less strict Sep 20, 2024
@demetriusfeijoo demetriusfeijoo marked this pull request as ready for review September 20, 2024 18:55
Copy link
Member

@ademarCardoso ademarCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove all hehehe rm -rf

@demetriusfeijoo
Copy link
Contributor Author

Lets remove all hehehe rm -rf

sudo rm -Rf / 🤣 🤣

@demetriusfeijoo demetriusfeijoo merged commit a152c42 into main Sep 23, 2024
3 of 6 checks passed
@demetriusfeijoo demetriusfeijoo deleted the SHAPE-7030-update-storyblok-client-version branch September 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants