feat(space-nuxt-base): add appBridgeSession #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
commented
Aug 23, 2024
| @@ -2,7 +2,8 @@ import type { AppSession } from '@storyblok/app-extension-auth'; | |||
|
|
|||
| declare module 'h3' { | |||
| interface H3EventContext { | |||
| appSession: AppSession; | |||
| appSession?: AppSession; | |||
There was a problem hiding this comment.
In case we disable oauth on a project, this can should be optional.
|
I've tested this locally and it worked. Feel free to apply some changes (if needed), and feel free to merge it once approved. |
demetriusfeijoo
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the app bridge middleware to add
appBridgeSessiontoevent.contextwhen app bridge authentication is successful.Why?
There are ways to get spaceId on the server side. We could explicitly include spaceId in http requests but it's tedious. If we're using OAuth, we could get it via
event.context.appSession. However, we don't have such thing for App Bridge. In case a project is using App Bridge only without OAuth, we need something likeevent.context.appBridgeSessionto get the authenticated session information on the server side.