Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(story): restructure story starter #80

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Aug 12, 2024

What?

This PR flattens the directory structure of Story Starter.

Why?

Story Starter's directory structure has been like this:

(root)
     ㄴ starters
           ㄴ nuxt

Initially we've decided on this structure because we were anticipating the addition of Next.js starter like (root)/starters/nextjs, and also common packages like (root)/packages/something. However, we don't have any plan to add Next.js starter in the near future, and this nested folder structure can be complicated to new users. So we could simplify the structure here first, and re-think if and when we decide to add Next.js starter.

@eunjae-lee eunjae-lee marked this pull request as ready for review August 12, 2024 12:53
Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

I was wondering if it would be nice renaming story-starter to nuxt-story-starter also, so when we have a nextjs version we could just name it as next-story-starter. Wdyt? 🤔

@eunjae-lee
Copy link
Contributor Author

LGTM 🙌

I was wondering if it would be nice renaming story-starter to nuxt-story-starter also, so when we have a nextjs version we could just name it as next-story-starter. Wdyt? 🤔

Good idea, thanks! I've renamed it :)

…space-tool-plugins into fix/restructure-story-starter
@eunjae-lee eunjae-lee merged commit 47968ff into main Aug 13, 2024
1 check passed
@eunjae-lee eunjae-lee deleted the fix/restructure-story-starter branch August 13, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants