fix(space-nuxt-starter): move default layout to nuxt-starter #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
force-pushed
the
fix/move-layout-to-starter
branch
from
224d185
to
0c7821f
Compare
|
FYI, space-tool-plugins/space-plugins/nuxt-starter/layouts/default.vue Lines 12 to 14 in 0c7821f this part, the typescript fails because it doesn't know our custom AppConfig typing. I will fix this in a separate PR. I tried, but it will likely take some time. |
BibiSebi
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves
layouts/default.vuefrom nuxt-base to nuxt-starter. If user has their ownlayouts/default.vue, then it will override the one from nuxt-base. To avoid this, we should just put the layout in the starter project, so that user can directly update the layout file as they want.