feat(space-nuxt-starter): use App Bridge #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
force-pushed
the
feat/use-app-bridge-for-starter
branch
from
f4b2561
to
30a241f
Compare
|
It'd be better to have a stable |
|
Should this be enabled by default even if it is undocumented atm? If we decide to revert this, we could just have a simple explenation in the readme, so that the user can decide to opt-in until this is released as stable and documented. WDYT? @eunjae-lee |
|
@BibiSebi this is a starter project, so it affects the users who is creating a new project from now on. And yes, I need to update the readme to include the fact that they have to enable app bridge on storyfront, which is not possible at the moment. But let me state it in the readme so that we can also know how much it's being in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR enables App Bridge in the nuxt-starter project by default.