feat(space-nuxt-base): remove init_oauth stale cookie deletion and move to app-extension-auth #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app-extension-auth
4 tasks
BibiSebi
changed the title
eunjae-lee
reviewed
Jul 3, 2024
| if (queryParams['init_oauth'] === 'true') { | ||
| return await sendRedirect( | ||
| event, | ||
| `${appConfig.auth.initOauthFlowUrl}?init_oauth=true`, |
There was a problem hiding this comment.
I don't think initOauthFlowUrl will likely already include ?, but just in case, could we do this a bit differently like
const url = new URL(appConfig.auth.initOauthFlowUrl);
// add `init_oauth` to `url`
eunjae-lee
approved these changes
Jul 3, 2024
eunjae-lee
deleted the
SHAPE-5947-remove-stale-cookie-inside-app-extension-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
init_oauthquery parameter.Why?
This problem and solution are necessary as there is no way to remove the cookies when a plugin is uninstalled. This can cause issues when a plugin is reinstalled as the old cookie is persisted. When app-extension-auth finds that there is a cookie, it will try to use it, even when it is not valid anymore.
JIRA: SHAPE-5947
This PR depends and can only be merged after #38 is merged and a new version of app-extension-auth is released.