Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Spotify Search plugin #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wesssel
Copy link

@wesssel wesssel commented Dec 4, 2022

Hi!

I wrote two guest articles on Storyblok related to this topic:

Would be great if we can add this plugin as an example

@BibiSebi
Copy link
Contributor

BibiSebi commented Jan 19, 2023

Hello @wesssel, thank you for creating this awesome field plugin. Looks great 🚀

A suggestion for the future (no need to implement it) would be to look into error handling. For example, how should the field plugin behave when the Spotify API returns an error?
I think it could be a nice extension also to the article you have written. 🔥

We are currently checking how we want to proceed with this repo, so until we decide that, we would keep this PR open and in case of any changes, instruct you of course on what to do.

PS: If you have any feedback regarding the developer experience when implementing a field plugin, we will be more than glad, to collect your thoughts on it, so do not hesitate to reach out 🙏

@wesssel
Copy link
Author

wesssel commented Jan 24, 2023

@BibiSebi thanks for the feedback! I will keep the error handling in mind for future plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants