Open
Conversation
DaveMiscampbell
commented
Mar 12, 2019
src/Storm.GoogleAnalytics.Reporting/Configuration/IGoogleAnalyticsServiceConfigurer.cs
Outdated
Show resolved
Hide resolved
...rm.GoogleAnalytics.Reporting/Configuration/Impl/GoogleAnalyticsRequestConfigurerConverter.cs
Outdated
Show resolved
Hide resolved
src/Storm.GoogleAnalytics.Reporting/Core/Impl/GoogleAnalyticsErrorResponse.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@Philo I've been working on updating this so I can use it in a .NET Core/.NET Standard project - I still need to fix the build process/cake script to use the .NET CLI instead of MSBuild - will let you know when it's ready for review |
This was referenced Mar 13, 2019
Closed
Contributor
Author
|
@Philo This is now ready for review - the build is failing in CI because the AppVeyor account it is associated with has too many artifacts stored. Otherwise the code looks to be working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.