Make dtmc model checker throw on unreachable condition when checking conditional probabilities.#946
Open
lukovdm wants to merge 2 commits into
Open
Make dtmc model checker throw on unreachable condition when checking conditional probabilities.#946lukovdm wants to merge 2 commits into
lukovdm wants to merge 2 commits into
Conversation
volkm
approved these changes
Jul 1, 2026
volkm
left a comment
volkm
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Maybe use a different type of exception such as InvalidPropertyException?
Contributor
Author
|
I was being consistent the the conditional MDP case, but I agree it is a bit weird. I will change both the DTMC and the MDP one to |
tquatmann
reviewed
Jul 3, 2026
|
|
||
| if (transformedModel.noTargetStates) { | ||
| storm::utility::vector::setVectorValues(result, transformedModel.beforeStates, storm::utility::zero<ValueType>()); | ||
| STORM_LOG_THROW(!conditionStates.empty(), storm::exceptions::InvalidPropertyException, |
Contributor
There was a problem hiding this comment.
Do we have to check that conditionStates are reachable from all relevant (i.e. initial) states?
Something like
auto const conditionGreaterZeroStates = storm::utility::graph::performProbGreater0(backwardTransitions, allStates, conditionStates);
STORM_LOG_THROW(goal.hasRelevantStates && goal.getRelevantStates().isSubsetOf(conditionGreaterZeroStates), ...);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes fix and added tests for this case.