Update harbour-storeman-installer #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olf0
added a commit
that referenced
this pull request
Dec 19, 2022
* Rectify content, language and formatting in double-fork-in-shell.md and apply to script (#180) * Preliminary fix, makes document inconsistent * Update comment (#181) * Rectify content, language and formatting * Update double-fork-in-shell-code.md * Update double-fork-in-shell-code.md * Update harbour-storeman-installer * Update double-fork-in-shell-code.md * Simplify * Simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * New changelog item in entry for v1.3.9 * Start to address topic "redirection" * Simplify redirections
Olf0
added a commit
that referenced
this pull request
Dec 19, 2022
* Delete space at line end in changelog * Adapt umask and version number (#173) * Fix typo (#174) * Align log levels with wording and v2.0.47 Also fix unbound variable due to copy'o. * Visually enhance "page-break" * Enhance epilogue * Kill killing kill, which almost killed me * Update harbour-storeman-installer.spec * Revert * Rectify content, language and formatting in double-fork-in-shell.md and apply to script (#180) * Preliminary fix, makes document inconsistent * Update comment (#181) * Rectify content, language and formatting * Update double-fork-in-shell-code.md * Update double-fork-in-shell-code.md * Update harbour-storeman-installer * Update double-fork-in-shell-code.md * Simplify * Simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * New changelog item in entry for v1.3.9 * Start to address topic "redirection" * Simplify redirections * No absolute paths to `sh` * v2.0.50 * Simplify * Add changelog entry * Update harbour-storeman-installer.spec * sh * No ` || true` * Update comment and a fix * `expr`→`$(( ))`, enhance code flow, update comment * Align with v2.0.50 & double-fork-in-shell.md * Update changlog with recent entries from v2 * Rectify log level for systemd * Align indention with v1.3.9 * Copied one block too much / twice: erased
Olf0
added a commit
that referenced
this pull request
Dec 19, 2022
* Rectify content, language and formatting in double-fork-in-shell.md and apply to script (#180) * Preliminary fix, makes document inconsistent * Update comment (#181) * Rectify content, language and formatting * Update double-fork-in-shell-code.md * Update double-fork-in-shell-code.md * Update harbour-storeman-installer * Update double-fork-in-shell-code.md * Simplify * Simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * New changelog item in entry for v1.3.9 * Start to address topic "redirection" * Simplify redirections
Olf0
added a commit
that referenced
this pull request
Dec 21, 2022
* Update harbour-storeman-installer.spec * Create harbour-storeman-installer.timer * Create harbour-storeman-installer.service * Update harbour-storeman-installer.service * Update harbour-storeman-installer.service * Execute `%post` section only when installing * Rectify virtual date for passing build-checks * Fix the fix * Fix path * Fix dates in changelog * Fix date in changelog * Update changelog for v2.0.0-beta1 * Add a changelog item in entry for v2.0.0 * Fix & simplify a bit, create v2.0.1-beta2 * Eliminate superfluous debug guidance * AccuracySec=1 * Enhance description * Enhance description * Update harbour-storeman-installer.timer * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Delete 50-harbour-storeman-installer.pkla * Fix path & eliminate polkit rule * Add `systemctl link` twice * Heavily reworked scriptlets in spec file * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Post (test-) release version increase * Update changelog with recent version number * Update and rename harbour-storeman-installer.service to harbour-storeman-installer.oneshot * Update harbour-storeman-installer.timer * Update harbour-storeman-installer.timer * Rename harbour-storeman-installer.oneshot to harbour-storeman-installer.service * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Remove superfluous `BuildRequires:` * Error reporting in journal via ExecStopPost= * Simplify * Add comments * Unify to "harbour-storeman" * Update harbour-storeman-installer.spec * Fix EcecStopPost statement * Rewrite `harbour-storeman-installer` shell script (#118) * Rewrite `harbour-storeman-installer` shell script * Adapt to rewritten `harbour-storeman-installer` script * harbour-storeman-installer → "$called" * Add missed "\n" * Fix spelling / grammar in comment * Clarify and extend comments * Clarify comment * Enhance %description * Use pkcon flags `-pvn` * Eliminate braced variable substitution "${}", … … where superfluous. * Fix formerly unbraced variable substitution * busybox's `date` knows no nanoseconds (+%N & -Ins)! * Update harbour-storeman-installer.spec * Remove superfluous `Requires:` * Delete harbour-storeman-installer.service * Delete harbour-storeman-installer.timer * Delete config * Delete harbour-storeman-installer.desktop * Add `\n` * Clarify comment * Use a single log-file (temporally) * Eliminate non-root use-case (#133) * Eliminate non-root use-case * Mode 0754 for `harbour-storeman-installer` script * Do not use pkcon's option -n; it is slow enough * Fix incorrectly placed, additional `\n` * Enhance sleeping for RPM to proceed; use `eval`; drop some shell flags for now * Fix indentation twice * Enhance comment * Enhance comment * Move sleeping * Enhance comment * Another second sleep * Update version & changelog * Fix CR'o (accidentally inserted line break) * Update comment * Add a single MR number to changelog entry item * Up initial sleeping from 1 to 3 seconds … … because `pkcon` might fail enqueuing a pkcon-job while an RPM transaction is unfinished, which usually is the one which called this script in a detached ("&") manner. During testing, the allocated time from calling this script in the `%posttrans` section of the spec file to the first `pkcon` call in line 59 appeared to be crucial: If it i too short, the `pkcon repo-set-data` call will be stalling for ever after being enqueued after the transaction, which installs the `harbour-storeman-installer` RPM. <sub>This can be easily observed with the slightly awkward `pkmon`: It is an "interactive" command line tool, permanently refreshing its displayed content, but not allowing for any user interaction (AFAICS), except for closing this tool, which I only achieved via `Ctrl-C` (one sure could alternatively send a `TERM` (terminate), `QUIT` or `HUP` (hang-up) signal).</sub> * Enhance output * Delete ' ' * [script] Update with enhancements from v1.3.6 * [spec file] Update with changes for v1.3.6 * Update harbour-storeman-installer.spec * Fix changelog * Fix copy'o * Update harbour-storeman-installer.spec * Fix the same copy'o at another place * Fix for v2.0.20 * Clarify code and comment WRT double forking * Fix self-obsoleting denoted by rpmlint * Rework failing repo refresh section and behaviour * Enhance comments for dependencies * Finalise changelog entry for v2.0.20 * Adapt to finalised v1.3.6 * Update to latest enhancements for v1.3.6, … … still in the `pkcon repo-set-data`-fails section * Fix & enhance `pkcon repo-set-data`-fails section … again * Trivial fix * Post release version increase * Fix gppid handover * Fix gppid handover * "Fix gppid" follow-up * Version increase * Fix which PPID is used * Split one log output in two, spatially & temporally * Also restart packagekit.service when out of hope * Ultimately fully finalise "detached script" variant * Ultimately fully finalise "detached script" variant * Update & mini-fix * New changelog entry for 2.0.45 * Fix typos in changelog * Fix twice pasted content * Fix by reverting nonsense * Align log levels with wording and v1.3.7 Also fix unbound variable due to copy'o. * Visually enhance "page-break" * Enhance epilogue * Increase version * Killing PPIDs was wrong! * Update harbour-storeman-installer.spec * Shorten redirections as of double-fork-in-shell.md * Simplify, according to double-fork-in-shell.md * Fix missing `"' and simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * Update comment * Start to address topic "redirection" * Simplify redirections * No absolute paths to `sh` * v2.0.50 (#184) * Delete space at line end in changelog * Adapt umask and version number (#173) * Fix typo (#174) * Align log levels with wording and v2.0.47 Also fix unbound variable due to copy'o. * Visually enhance "page-break" * Enhance epilogue * Kill killing kill, which almost killed me * Update harbour-storeman-installer.spec * Revert * Rectify content, language and formatting in double-fork-in-shell.md and apply to script (#180) * Preliminary fix, makes document inconsistent * Update comment (#181) * Rectify content, language and formatting * Update double-fork-in-shell-code.md * Update double-fork-in-shell-code.md * Update harbour-storeman-installer * Update double-fork-in-shell-code.md * Simplify * Simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * New changelog item in entry for v1.3.9 * Start to address topic "redirection" * Simplify redirections * No absolute paths to `sh` * v2.0.50 * Simplify * Add changelog entry * Update harbour-storeman-installer.spec * sh * No ` || true` * Update comment and a fix * `expr`→`$(( ))`, enhance code flow, update comment * Align with v2.0.50 & double-fork-in-shell.md * Update changelog with recent entries from v2 * Rectify log level for systemd * Align indention with v1.3.9 * Copied one block too much / twice: erased * Version increase and changelog entries * Oops, second parameter vanished lately * Two fixes * Fix * Fix changelog and up release version * Fix changelog * Swap waits * Update harbour-storeman-installer.spec * Swap sleep back and fix / uniforming quoting * Improve code and comments * Rectify changelog entry * Align info * Rename double-fork-in-shell-code.md to double-fork-in-shell.md * Post release version increase * Fix reference * Enhance comment * Update harbour-storeman-installer * Unify spelling * Unify spelling * Add comment with reference about double-forking * Add two comments * Add comment * Also handle packagekit hangs with `pkcon quit` Reference: https://en.opensuse.org/Pkcon * Missed change from commit before * Add basic argument checks … … primarily for interactive use * Fix basic argument checks * Increase version … … due to spoilt v2.1.3 release. * Enhance log formatting, plus … * ProcessIDs start at 1, not 0. * Move long missed `printf | systemd-cat`s **→** `systemd-cat | printf` * Make old rpmlint happy * Fix "make rpmlint happy" * Increase version number and add changelog entries * Update harbour-storeman-installer.spec
Olf0
added a commit
that referenced
this pull request
Dec 24, 2022
* Defer installation via detached script (#139) * Update harbour-storeman-installer.spec * Create harbour-storeman-installer.timer * Create harbour-storeman-installer.service * Update harbour-storeman-installer.service * Update harbour-storeman-installer.service * Execute `%post` section only when installing * Rectify virtual date for passing build-checks * Fix the fix * Fix path * Fix dates in changelog * Fix date in changelog * Update changelog for v2.0.0-beta1 * Add a changelog item in entry for v2.0.0 * Fix & simplify a bit, create v2.0.1-beta2 * Eliminate superfluous debug guidance * AccuracySec=1 * Enhance description * Enhance description * Update harbour-storeman-installer.timer * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Delete 50-harbour-storeman-installer.pkla * Fix path & eliminate polkit rule * Add `systemctl link` twice * Heavily reworked scriptlets in spec file * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Post (test-) release version increase * Update changelog with recent version number * Update and rename harbour-storeman-installer.service to harbour-storeman-installer.oneshot * Update harbour-storeman-installer.timer * Update harbour-storeman-installer.timer * Rename harbour-storeman-installer.oneshot to harbour-storeman-installer.service * Update harbour-storeman-installer.spec * Update harbour-storeman-installer.spec * Remove superfluous `BuildRequires:` * Error reporting in journal via ExecStopPost= * Simplify * Add comments * Unify to "harbour-storeman" * Update harbour-storeman-installer.spec * Fix EcecStopPost statement * Rewrite `harbour-storeman-installer` shell script (#118) * Rewrite `harbour-storeman-installer` shell script * Adapt to rewritten `harbour-storeman-installer` script * harbour-storeman-installer → "$called" * Add missed "\n" * Fix spelling / grammar in comment * Clarify and extend comments * Clarify comment * Enhance %description * Use pkcon flags `-pvn` * Eliminate braced variable substitution "${}", … … where superfluous. * Fix formerly unbraced variable substitution * busybox's `date` knows no nanoseconds (+%N & -Ins)! * Update harbour-storeman-installer.spec * Remove superfluous `Requires:` * Delete harbour-storeman-installer.service * Delete harbour-storeman-installer.timer * Delete config * Delete harbour-storeman-installer.desktop * Add `\n` * Clarify comment * Use a single log-file (temporally) * Eliminate non-root use-case (#133) * Eliminate non-root use-case * Mode 0754 for `harbour-storeman-installer` script * Do not use pkcon's option -n; it is slow enough * Fix incorrectly placed, additional `\n` * Enhance sleeping for RPM to proceed; use `eval`; drop some shell flags for now * Fix indentation twice * Enhance comment * Enhance comment * Move sleeping * Enhance comment * Another second sleep * Update version & changelog * Fix CR'o (accidentally inserted line break) * Update comment * Add a single MR number to changelog entry item * Up initial sleeping from 1 to 3 seconds … … because `pkcon` might fail enqueuing a pkcon-job while an RPM transaction is unfinished, which usually is the one which called this script in a detached ("&") manner. During testing, the allocated time from calling this script in the `%posttrans` section of the spec file to the first `pkcon` call in line 59 appeared to be crucial: If it i too short, the `pkcon repo-set-data` call will be stalling for ever after being enqueued after the transaction, which installs the `harbour-storeman-installer` RPM. <sub>This can be easily observed with the slightly awkward `pkmon`: It is an "interactive" command line tool, permanently refreshing its displayed content, but not allowing for any user interaction (AFAICS), except for closing this tool, which I only achieved via `Ctrl-C` (one sure could alternatively send a `TERM` (terminate), `QUIT` or `HUP` (hang-up) signal).</sub> * Enhance output * Delete ' ' * [script] Update with enhancements from v1.3.6 * [spec file] Update with changes for v1.3.6 * Update harbour-storeman-installer.spec * Fix changelog * Fix copy'o * Update harbour-storeman-installer.spec * Fix the same copy'o at another place * Fix for v2.0.20 * Clarify code and comment WRT double forking * Fix self-obsoleting denoted by rpmlint * Rework failing repo refresh section and behaviour * Enhance comments for dependencies * Finalise changelog entry for v2.0.20 * Adapt to finalised v1.3.6 * Update to latest enhancements for v1.3.6, … … still in the `pkcon repo-set-data`-fails section * Fix & enhance `pkcon repo-set-data`-fails section … again * Trivial fix * Post release version increase * Fix gppid handover * Fix gppid handover * "Fix gppid" follow-up * Version increase * Fix which PPID is used * Split one log output in two, spatially & temporally * Also restart packagekit.service when out of hope * Ultimately fully finalise "detached script" variant * Ultimately fully finalise "detached script" variant * Update & mini-fix * New changelog entry for 2.0.45 * Fix typos in changelog * Fix twice pasted content * Fix by reverting nonsense * Align log levels with wording and v1.3.7 Also fix unbound variable due to copy'o. * Visually enhance "page-break" * Enhance epilogue * Increase version * Killing PPIDs was wrong! * Update harbour-storeman-installer.spec * Shorten redirections as of double-fork-in-shell.md * Simplify, according to double-fork-in-shell.md * Fix missing `"' and simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * Update comment * Start to address topic "redirection" * Simplify redirections * No absolute paths to `sh` * v2.0.50 (#184) * Delete space at line end in changelog * Adapt umask and version number (#173) * Fix typo (#174) * Align log levels with wording and v2.0.47 Also fix unbound variable due to copy'o. * Visually enhance "page-break" * Enhance epilogue * Kill killing kill, which almost killed me * Update harbour-storeman-installer.spec * Revert * Rectify content, language and formatting in double-fork-in-shell.md and apply to script (#180) * Preliminary fix, makes document inconsistent * Update comment (#181) * Rectify content, language and formatting * Update double-fork-in-shell-code.md * Update double-fork-in-shell-code.md * Update harbour-storeman-installer * Update double-fork-in-shell-code.md * Simplify * Simplify * Add comment / explanation WRT SFOS-OBS' `tar_git` * New changelog item in entry for v1.3.9 * Start to address topic "redirection" * Simplify redirections * No absolute paths to `sh` * v2.0.50 * Simplify * Add changelog entry * Update harbour-storeman-installer.spec * sh * No ` || true` * Update comment and a fix * `expr`→`$(( ))`, enhance code flow, update comment * Align with v2.0.50 & double-fork-in-shell.md * Update changelog with recent entries from v2 * Rectify log level for systemd * Align indention with v1.3.9 * Copied one block too much / twice: erased * Version increase and changelog entries * Oops, second parameter vanished lately * Two fixes * Fix * Fix changelog and up release version * Fix changelog * Swap waits * Update harbour-storeman-installer.spec * Swap sleep back and fix / uniforming quoting * Improve code and comments * Rectify changelog entry * Align info * Rename double-fork-in-shell-code.md to double-fork-in-shell.md * Post release version increase * Fix reference * Enhance comment * Update harbour-storeman-installer * Unify spelling * Unify spelling * Add comment with reference about double-forking * Add two comments * Add comment * Also handle packagekit hangs with `pkcon quit` Reference: https://en.opensuse.org/Pkcon * Missed change from commit before * Add basic argument checks … … primarily for interactive use * Fix basic argument checks * Increase version … … due to spoilt v2.1.3 release. * Enhance log formatting, plus … * ProcessIDs start at 1, not 0. * Move long missed `printf | systemd-cat`s **→** `systemd-cat | printf` * Make old rpmlint happy * Fix "make rpmlint happy" * Increase version number and add changelog entries * Update harbour-storeman-installer.spec * Fix internal reference (#211) * Enhance section title and spelling of RPM (#212) * Rewrite README, enhance comments and up version (#213) * Enhance comment * Update README.md for first broad Storeman v2 release * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Overhaul fundamentally for v2 * Fixes * Update changelog (#217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.