Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): await promise and check error #1563

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

fforbeck
Copy link
Member

Resolve ESLint Promise Handling Error

Fixed the ESLint error by using assert.rejects to handle the promise returned by deviceCheater.setCurrentSpace. This ensures that the promise is properly managed and the test checks for expected rejections, addressing the ESLint rule that requires promises to be awaited, handled with .catch, or explicitly ignored.

@fforbeck fforbeck merged commit 86e7a46 into main Oct 14, 2024
3 checks passed
@fforbeck fforbeck deleted the fix/access-client-agent-test branch October 14, 2024 18:05
fforbeck added a commit that referenced this pull request Oct 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[18.1.0](upload-api-v18.0.3...upload-api-v18.1.0)
(2024-10-24)


### Features

* Generate Space proofs on the fly, on `access/claim`
([#1555](#1555))
([9e2b1d4](9e2b1d4))
* usage/record capability definition
([#1562](#1562))
([98c8a87](98c8a87))


### Fixes

* Error should refer to Resource, not Issuer
([#1558](#1558))
([25e35e3](25e35e3))
* repo URLs ([#1550](#1550))
([e02ddf3](e02ddf3))
* **test:** await promise and check error
([#1563](#1563))
([86e7a46](86e7a46))


### Other Changes

* Add `pnpm dev` to watch-build all packages
([#1533](#1533))
([07970ef](07970ef))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Felipe Forbeck <fforbeck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants