Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strictly require nodejs version #1264

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

alanshaw
Copy link
Member

This PR adds engines and engineStrict props to the package.json ensuring users are running the lower bound of what we're currently testing on in CI (v18) when installing.

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! it is also already documented in README, so we should be able to go

@Gozala Gozala merged commit bc9f427 into main Jan 17, 2024
3 checks passed
@Gozala Gozala deleted the feat/strict-required-node-engine branch January 17, 2024 16:50
travis pushed a commit that referenced this pull request Jan 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[12.1.0](w3up-client-v12.0.0...w3up-client-v12.1.0)
(2024-01-17)


### Features

* add a function to verify and return Abilities.
([#1252](#1252))
([2f026a2](2f026a2))
* re-export Store implementations from w3up-client
([#1266](#1266))
([b3c6b46](b3c6b46))
* strictly require nodejs version
([#1264](#1264))
([bc9f427](bc9f427))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants