feat: add reset command #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps this should be available in the client? |
gobengo
reviewed
Jan 24, 2024
| if (exportData) { | ||
| let data = AgentData.fromExport(exportData) | ||
| // do not reset the principal | ||
| data = await AgentData.create({ principal: data.principal, meta: data.meta }) |
There was a problem hiding this comment.
At first I read the code and didn't see how it would not just re-import the same proofs fromExport. This (imho) makes it more obvious what's going on. just a idea
Suggested change
| data = await AgentData.create({ principal: data.principal, meta: data.meta }) | |
| data = await AgentData.create({ principal: data.principal, meta: data.meta, delegations: undefined }) |
gobengo
approved these changes
Jan 24, 2024
vasco-santos
pushed a commit
that referenced
this pull request
Jan 25, 2024
🤖 I have created a release *beep* *boop* --- ## [7.5.0](v7.4.0...v7.5.0) (2024-01-25) ### Features * add reset command ([#170](#170)) ([8eea385](8eea385)) ### Bug Fixes * use remove from client ([#167](#167)) ([96966ba](96966ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reset command so you can reset you agent and login again to gain access to spaces. Retains agent DID.
I called this
resetand notlogoutbecause we can't guarantee the agent retains any delegations that are not associated with the currently logged in account(s)....and look I gained access to a space I didn't have before!