Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print falsy value in error messages #824

Merged
merged 1 commit into from
Dec 1, 2019
Merged

fix: print falsy value in error messages #824

merged 1 commit into from
Dec 1, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 30, 2019

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

Fixes an issue where a falsy value (referenced via {{value}}) would not be printed in the error message.

@P0lip P0lip added the t/bug Something isn't working label Nov 30, 2019
@P0lip P0lip self-assigned this Nov 30, 2019
@P0lip P0lip merged commit 49cb722 into develop Dec 1, 2019
@P0lip P0lip deleted the fix/message-falsy-values branch December 1, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marbemac marbemac marbemac approved these changes

@philsturgeon philsturgeon philsturgeon approved these changes

Assignees

@P0lip P0lip

Labels
t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P0lip @philsturgeon @marbemac