feat: rules are recommended by default #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
added
enhancement
P0lip
force-pushed
the
feat/default-recommended
branch
from
8780d4f
to
d71be0b
Compare
| expect(rules).toHaveProperty('test3.severity', DiagnosticSeverity.Warning); | ||
| }); | ||
|
|
||
| it('rules with no severity and no recommended set are treated as warnings', () => { |
There was a problem hiding this comment.
This message makes it sound like there is a crossover between severity and recommended, and im not sure there is?
There was a problem hiding this comment.
There is some. Basically, if there is no severity set, we either set a default value or disable it. Whether we set a default value or set it to off depends on the value of recommended.
In code, it covers this line https://github.com/stoplightio/spectral/pull/719/files#diff-7ba880b07a41aa1bf9a31d0a3bca8445R116
Co-Authored-By: Phil Sturgeon <me@philsturgeon.uk>
philsturgeon
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #447
Checklist
Does this PR introduce a breaking change?