chore: drop exceptions #1675
Merged
chore: drop exceptions #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulatulis
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
This looks good to me since it's just removing exceptions everywhere. However, if someone else from @stoplightio/void-crew wants to also take a look, I won't stop you :)
Only thing I would add is that the documentation should also be removed from meta.
This is going to happen automatically thanks to web hooks :) |
neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will reduce the noise in #1559
Do note that although exceptions are gone, they'll be replaced with #1021 which'll be actually a superset of present exceptions, so we're not losing any functionality.
Checklist
Does this PR introduce a breaking change?