export useChoices and other utilities for elements #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdVinyard
commented
Nov 13, 2023
EdVinyard
requested review from
a team and
chohmann
and removed request for
a team
chohmann
approved these changes
Nov 13, 2023
chohmann
left a comment
chohmann
left a comment
There was a problem hiding this comment.
LGTM except for a probably rogue console.log statement.
Comment on lines
23
to
24
| // eslint-disable-next-line no-console | ||
| console.log({ childNodes }); |
Contributor
Author
There was a problem hiding this comment.
Thank you for catching that!
mallachari
approved these changes
Nov 13, 2023
mallachari
left a comment
mallachari
left a comment
There was a problem hiding this comment.
Looks good and naming should be fine
| const childNodes = React.useMemo(() => calculateChildrenToShow(selectedChoice.type), [selectedChoice.type]); | ||
| const childNodes = React.useMemo(() => visibleChildren(selectedChoice.type), [selectedChoice.type]); | ||
| // eslint-disable-next-line no-console | ||
| console.log({ childNodes }); |
There was a problem hiding this comment.
Suggested change
| console.log({ childNodes }); |
Contributor
Author
There was a problem hiding this comment.
Thank you both for catching that!
EdVinyard
commented
Nov 13, 2023
Collaborator
|
🎉 This PR is included in version 4.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://github.com/stoplightio/platform-internal/issues/18370
json-schema-viewer and TryIt have been using different logic to determine if/how to display form-encoded schemas that have a
oneOfcombiner at the top level.Description
Expose a few utility features for use by related, downstream tools that also render JSON Schema in one way or another.
Specifically, the TryIt function of Elements will be able to reuse the same logic -- and thereby get the same visible results -- as json-schema-viewer.
How Has This Been Tested?
Existing functionality is being exported; no functional changes were made.
Types of changes
Checklist