Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Conversation

@lag-of-death
Copy link
Contributor

@lag-of-death lag-of-death commented Aug 13, 2019

Changes

This PR updates its dependencies to work with adjusted IHttpOperation type from @stoplight/types (stoplightio/types#50) because of stoplightio/prism#514.

(Temporarily, dist folder is included.)

Dependencies

"@stoplight/types": "git://github.com/stoplightio/types.git#fix/do-not-flatten-security",

Plan:

  • merge @stoplight/types
  • update dependency on @stoplight/types
  • have an approval
  • remove dist folder
  • merge

This PR should be merged second, after @stoplight/types.

Why github branches and no yalc? I was trying yalc first, but were having issues with nested .yalc folders (like .yalc/@stoplight/something/.yalc/@stoplight/something_else). Yarn, for some reason, couldn't have resolved dependencies.

Order of merging:

  1. @stoplight/types (Update IHttpOperation types#50)
  2. @stoplight/json-ref-resolver (build(deps): bump @stoplight/types from 9.1.2 to 11.0.0 #86)
  3. @stoplight/http-spec (Do not flatten securities http-spec#15) and @stoplight/spectral (chore: bump http-spec and types versions spectral#444)
  4. @stoplight/graphite (https://github.com/stoplightio/graphite/pull/211) and @stoplight/prism ([WIP] AND relations in security schemes prism#514)

@lag-of-death lag-of-death changed the title [wip] fix: do-not-flatten-security [wip] Update dependencies Aug 13, 2019
@lag-of-death lag-of-death changed the title [wip] Update dependencies Update dependencies Aug 13, 2019
@lag-of-death lag-of-death requested review from P0lip and pytlesk4 August 13, 2019 13:52
@pytlesk4
Copy link
Contributor

pytlesk4 commented Aug 13, 2019

@lag-of-death why is the dist folder included?

Why not just yalc types into whatever project you need it?

Copy link
Contributor

@pytlesk4 pytlesk4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶

@lag-of-death
Copy link
Contributor Author

@pytlesk4, yalcing types was the idea. But I was having issues witch deeper dependencies like .yalc/@stoplight/something/.yalc/@stoplight/types

Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dist, please. It does not need to be committed.

package.json Outdated
"dependencies": {
"@stoplight/json": "^2.2.2",
"@stoplight/types": "^9.1.2",
"@stoplight/types": "git://github.com/stoplightio/types.git#fix/do-not-flatten-security",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use npm version of types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@P0lip, we don't have npm version of types with the changes in it (IHttpOperation), or do we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's release it first and then bump the version.

@lag-of-death
Copy link
Contributor Author

@P0lip, are you OK with the changes?

@lag-of-death lag-of-death requested a review from P0lip August 14, 2019 11:48
@P0lip P0lip changed the title Update dependencies build(deps): bump @stoplight/types from Aug 14, 2019
@P0lip P0lip changed the title build(deps): bump @stoplight/types from build(deps): bump @stoplight/types Aug 14, 2019
@lag-of-death lag-of-death changed the title build(deps): bump @stoplight/types build(deps): bump @stoplight/types from 9.1.2 to 11.0.0 Aug 14, 2019
@lag-of-death lag-of-death merged commit 99e86a2 into master Aug 14, 2019
@pytlesk4
Copy link
Contributor

@lag-of-death delete the branch please, you leave them all the time.

@pytlesk4 pytlesk4 deleted the fix/do-not-flatten-security branch August 14, 2019 15:12
@lag-of-death
Copy link
Contributor Author

@pytlesk4, I beat my breast with humility

@pytlesk4
Copy link
Contributor

All good @lag-of-death, I got you.

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants