-
Notifications
You must be signed in to change notification settings - Fork 8
build(deps): bump @stoplight/types from 9.1.2 to 11.0.0 #86
Conversation
|
@lag-of-death why is the dist folder included? Why not just yalc types into whatever project you need it? |
pytlesk4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌶
|
@pytlesk4, yalcing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No dist, please. It does not need to be committed.
package.json
Outdated
| "dependencies": { | ||
| "@stoplight/json": "^2.2.2", | ||
| "@stoplight/types": "^9.1.2", | ||
| "@stoplight/types": "git://github.com/stoplightio/types.git#fix/do-not-flatten-security", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use npm version of types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@P0lip, we don't have npm version of types with the changes in it (IHttpOperation), or do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's release it first and then bump the version.
|
@P0lip, are you OK with the changes? |
|
@lag-of-death delete the branch please, you leave them all the time. |
|
@pytlesk4, I beat my breast with humility |
|
All good @lag-of-death, I got you. |
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This PR updates its dependencies to work with adjusted
IHttpOperationtype from@stoplight/types(stoplightio/types#50) because of stoplightio/prism#514.(Temporarily,
distfolder is included.)Dependencies
json-ref-resolver/package.json
Line 48 in 816018a
Plan:
@stoplight/types@stoplight/typesdistfolderThis PR should be merged second, after
@stoplight/types.Why github branches and no
yalc? I was tryingyalcfirst, but were having issues with nested.yalcfolders (like.yalc/@stoplight/something/.yalc/@stoplight/something_else). Yarn, for some reason, couldn't have resolved dependencies.Order of merging:
@stoplight/types(Update IHttpOperation types#50)@stoplight/json-ref-resolver(build(deps): bump @stoplight/types from 9.1.2 to 11.0.0 #86)@stoplight/http-spec(Do not flatten securities http-spec#15) and@stoplight/spectral(chore: bump http-spec and types versions spectral#444)@stoplight/graphite(https://github.com/stoplightio/graphite/pull/211) and@stoplight/prism([WIP] AND relations in security schemes prism#514)